<i>Editor command fails with spaces</i> status still Open with 2 other changes
by
dmitry
2011-02-04 02:49:18.
D 2011-02-04T02:49:18.174
J comment The\sfix\sfor\sbug\s[8d073be8808beaa7b614b6d489e729dfb51ac114]\sonly\sseems\sto\shave\sfixed\sthe\sissue\sfor\sthe\sgdiff\scommand.\sIf\seditor\scontains\sspaces,\sexecuting\sit\sstill\sfails.\r\n\r\n<verbatim>\r\nC:\\Docs\\Projects\\01.\sLean\sSDMC>fossil\scommit\r\nc:/Program\sFiles/Vim/vim73/gvim.exe\s"C:/<snipped>/ci-comment-5\r\n260D688DBC8.txt"\r\n'c:/Program'\sis\snot\srecognized\sas\san\sinternal\sor\sexternal\scommand,\r\noperable\sprogram\sor\sbatch\sfile.\r\nc:\\Docs\\Bin\\fossil.exe:\seditor\saborted\r\n</verbatim>\r\n\r\nDiff\sbelow\sfixes\sthis,\sbut\sa\sbetter\ssolution\swould\sprobably\sbe\sto\sextend\sthe\sportable_system\scommand\sto\scover\sall\suses\sof\sfossil_system\r\n\r\n<verbatim>\r\n---\ssrc/checkin.c\r\n+++\ssrc/checkin.c\r\n@@\s-442,11\s+442,11\s@@\r\n\s#if\sdefined(_WIN32)\r\n\s\s\sblob_add_cr(&text);\r\n\s#endif\r\n\s\s\sblob_write_to_file(&text,\szFile);\r\n\s\s\sif(\szEditor\s){\r\n-\s\s\s\szCmd\s=\smprintf("%s\s\\"%s\\"",\szEditor,\szFile);\r\n+\s\s\s\szCmd\s=\smprintf("\\"%s\\"\s\\"%s\\"",\szEditor,\szFile);\r\n\s\s\s\s\sprintf("%s\\n",\szCmd);\r\n\s\s\s\s\sif(\sfossil_system(zCmd)\s){\r\n\s\s\s\s\s\s\sfossil_panic("editor\saborted");\r\n\s\s\s\s\s}\r\n\s\s\s\s\sblob_reset(&text);\r\n</verbatim>
J resolution Open
K 995a864c5adf79456808d8f2bcd44c4959f46136
U dmitry
Z 10e4ec27b67dd6b8d882e04fff4a5d2e