<i>Patch to allow sidebox to be skinable.</i>.
by
anonymous
2010-02-16 19:44:24.
D 2010-02-16T19:44:24
J comment Small\spatch,\sof\smany\sI\shope,\sto\smake\smore\sof\sfossil\s'skinable'\r\n\r\nThis\spatch\srenames\sthe\ssidebox\sobject\s->\sinfobox,\sto\smake\sit\smore\suseable\selsewhere,\sand\sapplies\ssome\scss\sto\sthe\sdefault\sskins\sto\semulate\scurrent\slook\sand\sfeel.\r\n\r\nOnly\stested\sagainst\sFirefox\s3.5\sand\sIE8.\r\n\r\nPatch\sgenerated\sagainst\s[94bb313444]\r\n<verbatim>\r\nIndex:\ssrc/branch.c\r\n===================================================================\r\n---\ssrc/branch.c\r\n+++\ssrc/branch.c\r\n@@\s-229,11\s+230,11\s@@\r\n\r\n\s\s\sstyle_header("Branches");\r\n\s\s\sstyle_submenu_element("Timeline",\s"Timeline",\s"brtimeline");\r\n\s\s\slogin_anonymous_available();\r\n\s\s\scompute_leaves(0,\s1);\r\n-\s\sstyle_sidebox_begin("Nomenclature:",\s"33%");\r\n+\s\sstyle_infobox_begin("Nomenclature:");\r\n\s\s\s@\s<ol>\r\n\s\s\s@\s<li>\sAn\s<b>open\sbranch</b>\sis\sa\sbranch\sthat\shas\sone\sor\r\n\s\s\s@\smore\s<a\shref="leaves">open\sleaves.</a>\r\n\s\s\s@\sThe\spresence\sof\sopen\sleaves\spresumably\smeans\r\n\s\s\s@\sthat\sthe\sbranch\sis\sstill\sbeing\sextended\swith\snew\scheck-ins.</li>\r\n@@\s-240,11\s+241,11\s@@\r\n\s\s\s@\s<li>\sA\s<b>closed\sbranch</b>\sis\sa\sbranch\swith\sonly\r\n\s\s\s@\s<a\shref="leaves?closed">closed\sleaves</a>.\r\n\s\s\s@\sClosed\sbranches\sare\sfixed\sand\sdo\snot\schange\s(unless\sthey\sare\sfirst\r\n\s\s\s@\sreopened)</li>\r\n\s\s\s@\s</ol>\r\n-\s\sstyle_sidebox_end();\r\n+\s\sstyle_infobox_end();\r\n\r\n\s\s\sdb_prepare(&q,\r\n\s\s\s\s\s"SELECT\sDISTINCT\svalue\sFROM\stagxref"\r\n\s\s\s\s\s"\sWHERE\stagid=%d\sAND\svalue\sNOT\sNULL"\r\n\s\s\s\s\s"\s\s\sAND\srid\sIN\sleaves"\r\n\r\nIndex:\ssrc/descendants.c\r\n===================================================================\r\n---\ssrc/descendants.c\r\n+++\ssrc/descendants.c\r\n@@\s-322,19\s+322,19\s@@\r\n\s\s\s\s\sstyle_submenu_element("Open",\s"Open",\s"leaves");\r\n\s\s\s}\r\n\s\s\sstyle_header("Leaves");\r\n\s\s\slogin_anonymous_available();\r\n\s\s\scompute_leaves(0,\sshowAll\s?\s0\s:\sshowClosed\s?\s2\s:\s1);\r\n-\s\sstyle_sidebox_begin("Nomenclature:",\s"33%");\r\n+\s\sstyle_infobox_begin("Nomenclature:");\r\n\s\s\s@\s<ol>\r\n\s\s\s@\s<li>\sA\s<b>leaf</b>\sis\sa\scheck-in\swith\sno\sdescendants.</li>\r\n\s\s\s@\s<li>\sAn\s<b>open\sleaf</b>\sis\sa\sleaf\sthat\sdoes\snot\shave\sa\s"closed"\stag\r\n\s\s\s@\sand\sis\sthus\sassumed\sto\sstill\sbe\sin\suse.</li>\r\n\s\s\s@\s<li>\sA\s<b>closed\sleaf</b>\shas\sa\s"closed"\stag\sand\sis\sthus\sassumed\sto\r\n\s\s\s@\sbe\shistorical\sand\sno\slonger\sin\sactive\suse.</li>\r\n\s\s\s@\s</ol>\r\n-\s\sstyle_sidebox_end();\r\n+\s\sstyle_infobox_end();\r\n\r\n\s\s\sif(\sshowAll\s){\r\n\s\s\s\s\s@\s<h1>All\sleaves,\sboth\sopen\sand\sclosed:</h1>\r\n\s\s\s}else\sif(\sshowClosed\s){\r\n\s\s\s\s\s@\s<h1>Closed\sleaves:</h1>\r\n\r\nIndex:\ssrc/skins.c\r\n===================================================================\r\n---\ssrc/skins.c\r\n+++\ssrc/skins.c\r\n@@\s-156,11\s+156,19\s@@\r\n\s@\s/*\sThe\slabel/value\spairs\son\s(for\sexample)\sthe\svinfo\spage\s*/\r\n\s@\stable.label-value\sth\s{\r\n\s@\s\s\svertical-align:\stop;\r\n\s@\s\s\stext-align:\sright;\r\n\s@\s\s\spadding:\s0.2ex\s2ex;\r\n-@\s}');\r\n+@\s}\r\n+@\r\n+@\s/*\sInformation/instruction\sboxes\s*/\r\n+@\stable.infoBox\s{\r\n+@\s\s\sborder:2px\ssolid\s#606060;\r\n+@\s\s\sfloat:right;\r\n+@\s\s\swidth:33%;\r\n+@\s}\r\n+@');\r\n\s@\sREPLACE\sINTO\sconfig\sVALUES('header','<html>\r\n\s@\s<head>\r\n\s@\s<title>$<project_name>:\s$<title></title>\r\n\s@\s<link\srel="alternate"\stype="application/rss+xml"\stitle="RSS\sFeed"\r\n\s@\s\s\s\s\s\s\shref="$baseurl/timeline.rss">\r\n@@\s-361,11\s+369,18\s@@\r\n\s@\stable.label-value\sth\s{\r\n\s@\s\s\svertical-align:\stop;\r\n\s@\s\s\stext-align:\sright;\r\n\s@\s\s\spadding:\s0.2ex\s2ex;\r\n\s@\s}\r\n-@\s');\r\n+@\r\n+@\s/*\sInformation/instruction\sboxes\s*/\r\n+@\stable.infoBox\s{\r\n+@\s\s\sborder:2px\ssolid\s#a09048;\r\n+@\s\s\sfloat:right;\r\n+@\s\s\swidth:33%;\r\n+@\s}\r\n+@');\r\n\s@\sREPLACE\sINTO\sconfig\sVALUES('header','<html>\r\n\s@\s<head>\r\n\s@\s<title>$<project_name>:\s$<title></title>\r\n\s@\s<link\srel="alternate"\stype="application/rss+xml"\stitle="RSS\sFeed"\r\n\s@\s\s\s\s\s\s\shref="$baseurl/timeline.rss">\r\n@@\s-594,11\s+609,19\s@@\r\n\s@\s/*\sThe\slabel/value\spairs\son\s(for\sexample)\sthe\sci\spage\s*/\r\n\s@\stable.label-value\sth\s{\r\n\s@\s\s\svertical-align:\stop;\r\n\s@\s\s\stext-align:\sright;\r\n\s@\s\s\spadding:\s0.2ex\s2ex;\r\n-@\s}');\r\n+@\s}\r\n+@\r\n+@\s/*\sInformation/instruction\sboxes\s*/\r\n+@\stable.infoBox\s{\r\n+@\s\s\sborder:2px\ssolid\s#eeeeee;\r\n+@\s\s\sfloat:right;\r\n+@\s\s\swidth:33%;\r\n+@\s}\r\n+@');\r\n\s@\sREPLACE\sINTO\sconfig\sVALUES('header','<html>\r\n\s@\s<head>\r\n\s@\s<title>$<project_name>:\s$<title></title>\r\n\s@\s<link\srel="alternate"\stype="application/rss+xml"\stitle="RSS\sFeed"\r\n\s@\s\s\s\s\s\s\shref="$baseurl/timeline.rss">\r\n\r\nIndex:\ssrc/style.c\r\n===================================================================\r\n---\ssrc/style.c\r\n+++\ssrc/style.c\r\n@@\s-158,24\s+158,22\s@@\r\n\s\s\s\s\scgi_append_content("</font>\\n",\s-1);\r\n\s\s\s}\r\n\s}\r\n\r\n\s/*\r\n-**\sBegin\sa\sside-box\son\sthe\sright-hand\sside\sof\sa\spage.\s\sThe\stitle\sand\r\n-**\sthe\swidth\sof\sthe\sbox\sare\sgiven\sas\sarguments.\s\sThe\swidth\sis\susually\r\n-**\sa\spercentage\sof\stotal\sscreen\swidth.\r\n+**\sBegin\sa\sside-box\son\sthe\sright-hand\sside\sof\sa\spage.\s\sThe\stitle\r\n+**\sof\sthe\sbox\sis\sgiven\sas\sarguments.\r\n\s*/\r\n-void\sstyle_sidebox_begin(const\schar\s*zTitle,\sconst\schar\s*zWidth){\r\n-\s\s@\s<table\swidth="%s(zWidth)"\salign="right"\sborder="1"\scellpadding=5\r\n-\s\s@\s\svspace=5\shspace=5>\r\n+void\sstyle_infobox_begin(const\schar\s*zTitle){\r\n+\s\s@\s<table\sclass="infoBox">\r\n\s\s\s@\s<tr><td>\r\n\s\s\s@\s<b>%h(zTitle)</b>\r\n\s}\r\n\r\n\s/*\sEnd\sthe\sside-box\r\n\s*/\r\n-void\sstyle_sidebox_end(void){\r\n+void\sstyle_infobox_end(void){\r\n\s\s\s@\s</td></tr></table>\r\n\s}\r\n\r\n\s/*\s@-comment:\s//\s*/\r\n\s/*\r\n@@\s-379,10\s+377,15\s@@\r\n\s@\s/*\sThe\slabel/value\spairs\son\s(for\sexample)\sthe\sci\spage\s*/\r\n\s@\stable.label-value\sth\s{\r\n\s@\s\s\svertical-align:\stop;\r\n\s@\s\s\stext-align:\sright;\r\n\s@\s\s\spadding:\s0.2ex\s2ex;\r\n+@\s}\r\n+@\r\n+@\s/*\sInfo\sbox\s*/\r\n+@\stable.infoBox\s{\r\n+@\s\s\swidth:33%;\r\n\s@\s}\r\n\s;\r\n\r\n\s/*\r\n\s**\sWEBPAGE:\sstyle.css\r\n</verbatim>
J foundin 94bb313444
J private_contact 89fb7932f6cf1ff580ce979fd5eefb40af6860a4
J severity Cosmetic
J status Open
J title Patch\sto\sallow\ssidebox\sto\sbe\sskinable.
J type Feature_Request
K 993287b389d78384ca1ab16641e08885f04b898a
U anonymous
Z 03cdfc56de9abcbd2eb1ecf4ec2ac35c