Many hyperlinks are disabled.
Use anonymous login
to enable hyperlinks.
50 events by user stephan occurring around 2020-05-16 05:03:11.
|
2020-05-18
| ||
| 12:32 | Reverted [5abc0f6e7] because testing has shown the referrer to simply be too fragile and subject to browser-side whims (which also includes the option to send only the scheme and host, without the path, as the referrer, which breaks what that commit did). Now style.css supports both style.css/pagename and style.css?page=name, preferring the former, pending a decision on which one of those syntaxes the other devs prefer. ... (check-in: 45341a2869 user: stephan tags: style-css-revamp) | |
| 06:05 | Internal commentary on the validity of the global UI enable/disable approach to XHR handling. ... (check-in: 7a95a0f178 user: stephan tags: fileedit-ajaxify) | |
| 05:19 | Added optional fossil.fetch() beforesend/aftersend callbacks to allow us to... /efilepage now disables all input elements while AJAX requests are in-flight and updates the page with a 'wait' cursor. ... (check-in: 7e197260fd user: stephan tags: fileedit-ajaxify) | |
| 03:48 | • Edit [5abc0f6e79dfbfc5|5abc0f6e79]: Edit check-in comment. ... (artifact: 2e8f174c4b user: stephan) | |
| 03:41 | Replaced style.css?page=xxx with style.css/page, like the [style-css-revamp] branch does. ... (check-in: bc40707425 user: stephan tags: fileedit-ajaxify) | |
| 03:38 | Removed doc/help references to "overriding" CSS rules, as that no longer applies in this branch. ... (check-in: a21e26684f user: stephan tags: style-css-revamp) | |
| 03:24 | All /fileedit/ajax requests now do a CSRF check and fail with 403 if CSRF seems likely. ... (check-in: 88a69253cd user: stephan tags: fileedit-ajaxify) | |
| 02:59 | style.css now checks for a builtin file named after the first path component of the referer (sic), rather than PD("name"), however, we still have to emit style.css/PAGENAME in $stylesheet_url in order to pick up the the page-specific CSS, otherwise /style.css?id=... is the same for all pages and a page with its own style may pick up a cached copy without its own styles, or with the styles from another page. ... (check-in: 5abc0f6e79 user: stephan tags: style-css-revamp) | |
|
2020-05-17
| ||
| 19:55 | Removed accidental dual-emit of skin-level CSS. Copy/paste bug. ... (check-in: eddb5ac552 user: stephan tags: style-css-revamp) | |
| 19:49 | Eliminated an unnecessary allocation. Code style conformance tweaks. ... (check-in: e2a9fe4bc8 user: stephan tags: style-css-revamp) | |
| 18:56 | Cherrypick [100c67fa] for bootstrap skin fix. ... (check-in: 06c7d57d18 user: stephan tags: style-css-revamp) | |
| 17:52 | Proof of concept for my proposal of reworking how style.css emits CSS, as discussed in [https://fossil-scm.org/forum/forumpost/d63ff33063|forumpost/d63ff33063]. ... (check-in: ae10ddf330 user: stephan tags: style-css-revamp) | |
| 17:07 | Merged in trunk. ... (check-in: b9b746e50f user: stephan tags: fileedit-ajaxify) | |
| 06:40 | Minor style improvements. Dry-run mode is now OFF by default. Reordered checkboxes on the commit tab. Eliminated a couple more uses of the term 'stash' (for local edits), to avoid potential confusion with fossil's stash feature. ... (check-in: 42f2cd77d5 user: stephan tags: fileedit-ajaxify) | |
| 06:09 | More style tweaks. ... (check-in: 0209fa3277 user: stephan tags: fileedit-ajaxify) | |
| 04:50 | Updated bootstrap skin header to use $stylesheet_url instead of hard-coding the name and params. ... (check-in: 100c67fa50 user: stephan tags: fileedit-ajaxify) | |
| 04:45 | Fixed input-with-label > label style for skins which set label display to block. ... (check-in: 0002b7d714 user: stephan tags: fileedit-ajaxify) | |
| 04:08 | Replaced /fileedit?ajax=blah with /fileedit/blah. This simplifies the passing of URL arguments, eliminating it in several cases, and just looks nicer. ... (check-in: 2c4e7c3785 user: stephan tags: fileedit-ajaxify) | |
| 03:35 | Several layout tweaks. The 'Prefer delta?' option is now checked by default if the repo contains any deltas and the forbid-delta-manifests setting is not true (that setting trumps this checkbox, in any case). ... (check-in: 25f5f592d1 user: stephan tags: fileedit-ajaxify) | |
| 03:32 | Moved fileedit-specific CSS to style.fileedit.css, as enabled by previous commit [d661c12cbade]. ... (check-in: 95f1753ffb user: stephan tags: fileedit-ajaxify) | |
| 03:19 | Extended style.css to optionally be able to load page-specific CSS if the 'page' URL param is provided and a builtin file named style.{{page}}.css is found. The stylesheet_url TH1 var now adds URL param page=g.zPath if builtin file style.{{g.zPath}}.css is available. ... (check-in: d661c12cba user: stephan tags: fileedit-ajaxify) | |
|
2020-05-16
| ||
| 17:05 | Clear the preview/diff views after a non-dry-run commit. Added toggle to include (or not) manifest in the commit response. Added branch name to finfo objects from the server so that we have the branch names for stashed non-leaf edits. Extended fossil.connectPagePreviewers() to be able to optionally specify methods, instead of element IDs, for the 'from' source and 'to' target, in order to support custom editor/preview widgets. ... (check-in: b5944d4ede user: stephan tags: fileedit-ajaxify) | |
| 06:34 | Removed the hard-coded restriction against using /fileedit on the main fossil repo and tweaked an error message. ... (check-in: 3c795e877c user: stephan tags: fileedit-ajaxify) | |
| 05:42 | Include the branch name, if known, in stashed fileinfo objects, and use a longer hash prefix for storing checkin-to-branch mappings (noting that the record does not notice if a checkin is later moved to another branch). (We only know the branch names of leaf checkins we've loaded, but now cache them in persistent storage if possible.) Renamed an internal cache key for consistency. ... (check-in: 8573443f32 user: stephan tags: fileedit-ajaxify) | |
| 05:03 | Added widget to browse/select locally-edited files. Related cleanups and refactoring. ... (check-in: aefceac57c user: stephan tags: fileedit-ajaxify) | |
|
2020-05-15
| ||
| 22:13 | Added fileedit-content-replaced event for notification when content is replaced. Clear preview/diff views on fileedit-content-replaced. Changed the interface for providing custom content getter/setter. Fixed the load file button in the file selection widget - it's no longer cleared. ... (check-in: 6f2649b9b0 user: stephan tags: fileedit-ajaxify) | |
| 19:25 | Simplified the previous commit considerably. ... (check-in: 525bec99a3 user: stephan tags: fileedit-ajaxify) | |
| 19:11 | Corrected fossil.storage's use of hasOwnProperty() for the case of the fallback transient storage object. ... (check-in: a863592e08 user: stephan tags: fileedit-ajaxify) | |
| 18:54 | Completed a half-written sentence in the fileedit docs. ... (check-in: d701631ec7 user: stephan tags: fileedit-ajaxify) | |
| 18:43 | /fileedit now uses fileStorage or sessionStorage, if available, to store unsaved local edits to the 7 most recently edited checkin/file combinations. TODO: make that configurable and offer a widget to manage that stash and quickly switch between those files. It warns loudly if persistent storage is not available. ... (check-in: d130f35687 user: stephan tags: fileedit-ajaxify) | |
| 04:40 | Modernized sbsdiff.js a tiny bit, adapted it to optionally be callable multiple times via fossil.page.tweakSbsDiffs(), and activate that when fileedit's sbs diff is refreshed. ... (check-in: dd46579617 user: stephan tags: fileedit-ajaxify) | |
| 04:20 | Internally rearranged how diff flags are passed around, in anticipation of having to refactor for wiki/forum diffs. Added annotate/blame links to /fileedit's first tab. ... (check-in: 39a5241b6f user: stephan tags: fileedit-ajaxify) | |
| 04:20 | • Edit [2cccc12d0482cc13|2cccc12d04]: Edit check-in comment. ... (artifact: 8e7ab9706d user: stephan) | |
| 04:19 | • Edit [d9fffa4c58686fa5|d9fffa4c58]: Edit check-in comment. ... (artifact: 97fcf6980b user: stephan) | |
| 03:35 | Cleaned up some JSON output using the new %!j format. ... (check-in: d9fffa4c58 user: stephan tags: fileedit-ajaxify) | |
| 03:34 | Added %!j to %j, which means to include double quotes around the resulting JSON string, and added the corresponding flag to encode_json_string_literal(). ... (check-in: 2cccc12d04 user: stephan tags: fileedit-ajaxify) | |
| 02:39 | Fixed multi-line commit comment (was not being submitted with commit) and change page title to reflect the file being edited, both per forum feedback. ... (check-in: ef2166a0ac user: stephan tags: fileedit-ajaxify) | |
| 02:27 | Added submenu Edit entry, when appropriate, to /file, per forum feedback. ... (check-in: 4818e7fdac user: stephan tags: fileedit-ajaxify) | |
| 01:35 | Fix a potential null deref in sample JS code. ... (check-in: d361947c8d user: stephan tags: fileedit-ajaxify) | |
|
2020-05-14
| ||
| 23:34 | EOL conversion: had neglected to pass that option on in the ajax request. Fixed a bug which caused duplicate CRs to get injected into force-to-windows-EOL conversions. ... (check-in: 439f446df6 user: stephan tags: fileedit-ajaxify) | |
| 15:10 | Restructured fileedit-page.md to give more space to/explanation of each caveat/warning bullet point (each of which is now in its own subsection). ... (check-in: 33146972e6 user: stephan tags: fileedit-ajaxify) | |
| 07:29 | Added a warning about EOL normalization of files with mixed EOL styles. ... (check-in: b83ff3f421 user: stephan tags: fileedit-ajaxify) | |
| 07:14 | Added www/fileedit-page.md, documenting how to integrate syntax highlighting and replace the editor widget. Added fossil.page.replaceEditorElement() to facility replacing the editor widget. ... (check-in: 909a48e378 user: stephan tags: fileedit-ajaxify) | |
| 04:46 | Expanded the fileedit-preview-updated event data to include the mimetype and preview mode so that listeners can make a better-informed decision about how/whether to handle the content. ... (check-in: e988ed904a user: stephan tags: fileedit-ajaxify) | |
| 04:32 | Added fileedit-preview-updated event, for use in hooking up 3rd-party syntax highlighting to the preview. (Tested locally with highlightjs.) ... (check-in: 8e293f959a user: stephan tags: fileedit-ajaxify) | |
| 04:14 | Removed some dead code. ... (check-in: 4619c9a772 user: stephan tags: fileedit-ajaxify) | |
| 04:13 | Added a parameter to encode_json_string_literal() to allow it to return its output string length, saving a strlen() call in vxprintf() %j. ... (check-in: 57edd18144 user: stephan tags: fileedit-ajaxify) | |
| 03:55 | Minor help text, style, and layout tweaks. ... (check-in: 28b2261b75 user: stephan tags: fileedit-ajaxify) | |
| 03:39 | The filename/version block on the first fileedit tab is now generated completely dynamically, rather than being filled out with '???' with broken links before a file is loaded. ... (check-in: 371b162ff3 user: stephan tags: fileedit-ajaxify) | |
| 03:00 | fileedit: now gets the file perms via the response header and updates the Is Executable checkbox accordingly. Similary, mimetype is now harvested from the response headers and is used, in place of file extensions, for the "is this a wiki page?" determination. Added fossil-level event infrastructure to allow pages to communicate page-specific events to skin-injected/user-supplied JS code, and fileedit now emits a fileedit-file-loaded event when it loads a new file. Replaced old uses of the term "save" with "commit", per forum feedback. ... (check-in: f1b2e509e7 user: stephan tags: fileedit-ajaxify) | |