Fossil

Timeline
Login

Timeline

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

50 events by user stephan occurring around 2020-05-18 03:24:51.

2020-05-28
13:44
Per forum discussion, moved the /fileedit ajax dispatching back down below the login check, but have it emit a JSON response if an ajax route was requested, else an HTML response. ... (check-in: 62263b9cb0 user: stephan tags: trunk)
13:27
fossil.fetch() now uses onreadystatechange instead of onload because the latter does not handle connection errors and timeouts. Added timeout option to fossil.fetch() with a default of 15s. Corrected non-closing of a failed transaction when fileedit/commit fails. ... (check-in: 6849d9a557 user: stephan tags: trunk)
12:16
Moved /fileedit permissions check below the ajax dispatching check, as ajax bootstrapping performs that check itself, along with a CSRF check for write-mode requests, and emits a JSON-format response (as opposed to HTML) if it fails. ... (check-in: 13e26db403 user: stephan tags: trunk)
12:02
Removed fileedit-glob from the list of syncable config options. It must be explicitly set on each repo where it is desired. ... (check-in: d6341b3a55 user: stephan tags: trunk)
10:22 Edit [064c1c95889feef2|064c1c9588]: Edit check-in comment. ... (artifact: 1810a0f202 user: stephan)
09:47
Added /fileedit to changes.wiki. ... (check-in: 2c9aa1b939 user: stephan tags: trunk)
09:40
Introducing the /fileedit page. ... (check-in: 1243bf3999 user: stephan tags: trunk)
09:18
Reworked how style.css is emitted: all default rules first, then page-specific rules (if passed name=PAGENAME and if builtin file style.PAGENAME.css exists), then the skin. This increases the default style.css output by only approx. 800 bytes before compression (approx. 300 after compression). Has no visual impact on existing built-in skins, and none is expected on 3rd-party skin edits. See [https://fossil-scm.org/forum/forumpost/d63ff33063|/forumpost/d63ff33063] for discussion. ... (check-in: 064c1c9588 user: stephan tags: trunk)
08:55
Editing forum posts now applies delta compression to the edits. ... (check-in: 5b7888c994 user: stephan tags: trunk)
08:48
Add --reset flag to add/rm/addremove commands. ... (check-in: e0fc98caa1 user: stephan tags: trunk)
2020-05-27
19:22
Updated release version number in index.wiki. ... (check-in: c0a91653ab user: stephan tags: trunk)
07:56
s/checkin/check-in/ in the help tab, per forum feedback. ... (Closed-Leaf check-in: 91948d3afa user: stephan tags: fileedit-ajaxify)
2020-05-26
07:42
Removed a no-longer-true line from the fileedit help tab. ... (check-in: 616333e5ba user: stephan tags: fileedit-ajaxify)
07:16
Merged in trunk. ... (Closed-Leaf check-in: 58ee06450c user: stephan tags: unaddremove-command)
06:56
merged in trunk ... (Closed-Leaf check-in: a2b0ed37af user: stephan tags: forum-edit-deltify)
06:47
merged in trunk. ... (Closed-Leaf check-in: fe018289e3 user: stephan tags: style-css-revamp)
06:43
Merged in trunk. ... (check-in: 559807ba86 user: stephan tags: fileedit-ajaxify)
2020-05-21
06:32
Added a doc section about CSRF/HTTP Referrer. Other minor doc/message cleanups. ... (check-in: 6de7e48021 user: stephan tags: fileedit-ajaxify)
2020-05-18
12:32
Reverted [5abc0f6e7] because testing has shown the referrer to simply be too fragile and subject to browser-side whims (which also includes the option to send only the scheme and host, without the path, as the referrer, which breaks what that commit did). Now style.css supports both style.css/pagename and style.css?page=name, preferring the former, pending a decision on which one of those syntaxes the other devs prefer. ... (check-in: 45341a2869 user: stephan tags: style-css-revamp)
06:05
Internal commentary on the validity of the global UI enable/disable approach to XHR handling. ... (check-in: 7a95a0f178 user: stephan tags: fileedit-ajaxify)
05:19
Added optional fossil.fetch() beforesend/aftersend callbacks to allow us to... /efilepage now disables all input elements while AJAX requests are in-flight and updates the page with a 'wait' cursor. ... (check-in: 7e197260fd user: stephan tags: fileedit-ajaxify)
03:48 Edit [5abc0f6e79dfbfc5|5abc0f6e79]: Edit check-in comment. ... (artifact: 2e8f174c4b user: stephan)
03:41
Replaced style.css?page=xxx with style.css/page, like the [style-css-revamp] branch does. ... (check-in: bc40707425 user: stephan tags: fileedit-ajaxify)
03:38
Removed doc/help references to "overriding" CSS rules, as that no longer applies in this branch. ... (check-in: a21e26684f user: stephan tags: style-css-revamp)
03:24
All /fileedit/ajax requests now do a CSRF check and fail with 403 if CSRF seems likely. ... (check-in: 88a69253cd user: stephan tags: fileedit-ajaxify)
02:59
style.css now checks for a builtin file named after the first path component of the referer (sic), rather than PD("name"), however, we still have to emit style.css/PAGENAME in $stylesheet_url in order to pick up the the page-specific CSS, otherwise /style.css?id=... is the same for all pages and a page with its own style may pick up a cached copy without its own styles, or with the styles from another page. ... (check-in: 5abc0f6e79 user: stephan tags: style-css-revamp)
2020-05-17
19:55
Removed accidental dual-emit of skin-level CSS. Copy/paste bug. ... (check-in: eddb5ac552 user: stephan tags: style-css-revamp)
19:49
Eliminated an unnecessary allocation. Code style conformance tweaks. ... (check-in: e2a9fe4bc8 user: stephan tags: style-css-revamp)
18:56
Cherrypick [100c67fa] for bootstrap skin fix. ... (check-in: 06c7d57d18 user: stephan tags: style-css-revamp)
17:52
Proof of concept for my proposal of reworking how style.css emits CSS, as discussed in [https://fossil-scm.org/forum/forumpost/d63ff33063|forumpost/d63ff33063]. ... (check-in: ae10ddf330 user: stephan tags: style-css-revamp)
17:07
Merged in trunk. ... (check-in: b9b746e50f user: stephan tags: fileedit-ajaxify)
06:40
Minor style improvements. Dry-run mode is now OFF by default. Reordered checkboxes on the commit tab. Eliminated a couple more uses of the term 'stash' (for local edits), to avoid potential confusion with fossil's stash feature. ... (check-in: 42f2cd77d5 user: stephan tags: fileedit-ajaxify)
06:09
More style tweaks. ... (check-in: 0209fa3277 user: stephan tags: fileedit-ajaxify)
04:50
Updated bootstrap skin header to use $stylesheet_url instead of hard-coding the name and params. ... (check-in: 100c67fa50 user: stephan tags: fileedit-ajaxify)
04:45
Fixed input-with-label > label style for skins which set label display to block. ... (check-in: 0002b7d714 user: stephan tags: fileedit-ajaxify)
04:08
Replaced /fileedit?ajax=blah with /fileedit/blah. This simplifies the passing of URL arguments, eliminating it in several cases, and just looks nicer. ... (check-in: 2c4e7c3785 user: stephan tags: fileedit-ajaxify)
03:35
Several layout tweaks. The 'Prefer delta?' option is now checked by default if the repo contains any deltas and the forbid-delta-manifests setting is not true (that setting trumps this checkbox, in any case). ... (check-in: 25f5f592d1 user: stephan tags: fileedit-ajaxify)
03:32
Moved fileedit-specific CSS to style.fileedit.css, as enabled by previous commit [d661c12cbade]. ... (check-in: 95f1753ffb user: stephan tags: fileedit-ajaxify)
03:19
Extended style.css to optionally be able to load page-specific CSS if the 'page' URL param is provided and a builtin file named style.{{page}}.css is found. The stylesheet_url TH1 var now adds URL param page=g.zPath if builtin file style.{{g.zPath}}.css is available. ... (check-in: d661c12cba user: stephan tags: fileedit-ajaxify)
2020-05-16
17:05
Clear the preview/diff views after a non-dry-run commit. Added toggle to include (or not) manifest in the commit response. Added branch name to finfo objects from the server so that we have the branch names for stashed non-leaf edits. Extended fossil.connectPagePreviewers() to be able to optionally specify methods, instead of element IDs, for the 'from' source and 'to' target, in order to support custom editor/preview widgets. ... (check-in: b5944d4ede user: stephan tags: fileedit-ajaxify)
06:34
Removed the hard-coded restriction against using /fileedit on the main fossil repo and tweaked an error message. ... (check-in: 3c795e877c user: stephan tags: fileedit-ajaxify)
05:42
Include the branch name, if known, in stashed fileinfo objects, and use a longer hash prefix for storing checkin-to-branch mappings (noting that the record does not notice if a checkin is later moved to another branch). (We only know the branch names of leaf checkins we've loaded, but now cache them in persistent storage if possible.) Renamed an internal cache key for consistency. ... (check-in: 8573443f32 user: stephan tags: fileedit-ajaxify)
05:03
Added widget to browse/select locally-edited files. Related cleanups and refactoring. ... (check-in: aefceac57c user: stephan tags: fileedit-ajaxify)
2020-05-15
22:13
Added fileedit-content-replaced event for notification when content is replaced. Clear preview/diff views on fileedit-content-replaced. Changed the interface for providing custom content getter/setter. Fixed the load file button in the file selection widget - it's no longer cleared. ... (check-in: 6f2649b9b0 user: stephan tags: fileedit-ajaxify)
19:25
Simplified the previous commit considerably. ... (check-in: 525bec99a3 user: stephan tags: fileedit-ajaxify)
19:11
Corrected fossil.storage's use of hasOwnProperty() for the case of the fallback transient storage object. ... (check-in: a863592e08 user: stephan tags: fileedit-ajaxify)
18:54
Completed a half-written sentence in the fileedit docs. ... (check-in: d701631ec7 user: stephan tags: fileedit-ajaxify)
18:43
/fileedit now uses fileStorage or sessionStorage, if available, to store unsaved local edits to the 7 most recently edited checkin/file combinations. TODO: make that configurable and offer a widget to manage that stash and quickly switch between those files. It warns loudly if persistent storage is not available. ... (check-in: d130f35687 user: stephan tags: fileedit-ajaxify)
04:40
Modernized sbsdiff.js a tiny bit, adapted it to optionally be callable multiple times via fossil.page.tweakSbsDiffs(), and activate that when fileedit's sbs diff is refreshed. ... (check-in: dd46579617 user: stephan tags: fileedit-ajaxify)
04:20
Internally rearranged how diff flags are passed around, in anticipation of having to refactor for wiki/forum diffs. Added annotate/blame links to /fileedit's first tab. ... (check-in: 39a5241b6f user: stephan tags: fileedit-ajaxify)