Fossil

Timeline
Login

Timeline

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

96 check-ins using file src/main.c version 302650afec

2018-08-17
01:27
Allow + signs in email addresses. Added a comment to link to a source giving the true limit on legal characters in email addresses, which are currently far less restrictive than our newly-expanded limits. ... (check-in: 1bfd790352 user: wyoung tags: trunk)
2018-08-16
20:48
Enhance the backoffice to automatically purge stale entries from the emailblob table, if that table exists. ... (check-in: 4c7edd4cfd user: drh tags: trunk)
19:51
Do not put "Return-Path:" headers in notification emails to be sent. That is a violation of standards as only the receiving SMTP server should add the Return-Path header. Instead, include a custom X-Fossil-From: header that downstream software can use (if desired) to set the envelope header of the message. ... (check-in: 731836b869 user: drh tags: trunk)
18:56
For email notifications abound events from a single user (such as individual forum post notifications) make the From: address be a "noreply" hash based on the users human-readable name or handle. Always include a Return-Path: field in the header that is the email-self setting, to be used by MTUs that need to bounce the message. ... (check-in: 475c9d11e9 user: drh tags: trunk)
16:45
Do not show posts that are awaiting moderation to users without moderator privilege unless they are the same user that generated the post in the first place. ... (check-in: 16c42a0808 user: drh tags: trunk)
16:26
Update the built-in SQLite to the latest trunk version which includes the fix for EXPLAIN QUERY PLAN for the query that runs the /forum page. ... (check-in: f8994f8975 user: drh tags: trunk)
16:13
Adjust the /forum page so that it for users without forum moderator privilege, it pretends that unmoderated posts do not exist, and for user with moderator privilege it paints an "Awaiting Moderator Approval" message on posts that need moderation. ... (check-in: ef7f85eecd user: drh tags: trunk)
12:31
Fix the /forum page so that it links to the most recent post. ... (check-in: b0ae37c039 user: drh tags: trunk)
07:21
Improved locality of a variable. No functional change. ... (check-in: 09103fd2f0 user: wyoung tags: trunk)
07:06
Posts are now hidden on the /forum page if they're marked as private (i.e. needing moderator attention) and they were posted by another user, except when the user is a moderator. (Closed because a different method was implemented on trunk.) ... (Closed-Leaf check-in: 779eaaae81 user: wyoung tags: hide-post-if-needmod)
06:36
Replaced a declare-and-init line pair with a single define-with-value line. No functional change. ... (check-in: 8f47c3f653 user: wyoung tags: trunk)
02:03
Fix the hextoblob() function so that does not report out-of-memory if the size of the input string is zero bytes. This fixes the instances of "out-of-memory" reports when accessing the /alerts page without an argument. ... (check-in: 5519c6b8fc user: drh tags: trunk)
01:46
Fixes to the /webmail screen ... (check-in: a24de3f9fc user: drh tags: trunk)
01:43
Add comments to the /register page implementation. No logic changes. ... (check-in: a4419c6c02 user: drh tags: trunk)
2018-08-15
21:28
Do not issue a warning about duplicate branch names when doing a --private check-in. ... (check-in: d7e45aae70 user: drh tags: trunk)
20:50
Improved title on on the /forum page. ... (check-in: dbd96b2c74 user: drh tags: trunk)
20:41
On the main /forum screen, provide the new n= and x= query parameters to enable access to older threads. ... (check-in: aff20904fa user: drh tags: trunk)
20:17
On the "Recent Threads" page (/forum) show the number of messages and the duration of each thread. ... (check-in: a50dfe6fae user: drh tags: trunk)
18:14
Improvements to self-register (the /register page) so that it works correctly for users how are already subscribers and enter the subscriber email. ... (check-in: 4c43f2cd43 user: drh tags: trunk)
15:53
Remove an db_begin_transaction() that had no matching db_end_transaction(). ... (check-in: b2fca3dd4d user: drh tags: trunk)
12:09
Change the default markup language for Forum to Markdown. ... (check-in: 5f3cb278fd user: drh tags: trunk)
11:05
Update to openssl-1.0.2p ... (check-in: 38638cfcdd user: jan.nijtmans tags: trunk)
2018-08-14
13:05
Don't use "file nativename" in makemake.tcl, because it gives a different win/Makefile.msc when run on UNIX ... (check-in: af80be5cef user: jan.nijtmans tags: trunk)
05:59
Changed all of the "sendmail -t" commands to "sendmail -ti" to make it ignore lines containing only a dot; we use EOF to signal "end of message," so we don't need the second signal. This is separate from the smtp.c fix in [51740ce45f]: that's only used when Fossil speaks directly to an SMTP server, where a leading dot is treated somewhat differently than the lone dot rule for sendmail(1)'s stdin. This problem with leading dots was diagnosed by gumblex, /forumpost/4290f75ba1. ... (check-in: 8c0ec30bc3 user: wyoung tags: trunk)
04:39
URL fix ... (check-in: 6787aac97f user: wyoung tags: trunk)
03:55
The blob-to-SMTP encoding logic was not strictly following RFC 5321 in that it was only dealing with the lone dot on the line case, doubling it to prevent the SMTP server from interpreting that as end-of-message. It missed the case where, if anything follows the dot, SMTP drops the leading dot, so you must also double the leading dot in that case. Basically, you always double a leading dot, regardless of line length. This only affects Fossil's direct-to-SMTP email sending case, not those that send via a piped command or via DB. That is dealt with later in [8c0ec30bc3]. ... (check-in: 51740ce45f user: wyoung tags: trunk)
2018-08-13
03:51
Covered capability 7 in the forum.wiki document, and made several improvements to the "Using the Moderation Feature" section. ... (check-in: 31631b756e user: wyoung tags: trunk)
03:23
Assorted minor improvements to the www/alerts.md document. The major one is re-emphasizing the need to give capability 7 to some user or user category. Ask me how I came to think this necessary. :) ... (check-in: 3e75a683ef user: wyoung tags: trunk)
01:11
Typo fix ... (check-in: c3d9c8e082 user: wyoung tags: trunk)
00:59
More forum.wiki tweaks ... (check-in: 26424763c7 user: wyoung tags: trunk)
00:31
Assorted improvements to the forum.wiki document, mainly to the new moderation material. ... (check-in: c1be550832 user: wyoung tags: trunk)
2018-08-12
23:24
Added the "How Moderation Works" section to www/forum.wiki, and improved the newly-renamed "Using the Moderation Feature" section as a result. ... (check-in: 812dd52c7d user: wyoung tags: trunk)
22:27
Added "id"s to every header tag in the forum.wiki document, so you can create links to sub-sections. ... (check-in: 03c298dcb9 user: wyoung tags: trunk)
21:40
Fixed a few references to MIME type "text/x-fossil" in the fileformat document. It's "text/x-fossil-wiki" everywhere else. ... (check-in: e00cdbe702 user: wyoung tags: trunk)
21:35
Add /forum link to sitemap if user has RdForum capability ... (check-in: 5ad7222f4a user: wyoung tags: trunk)
10:42
Merge the fix to the login-by-email-address patch. ... (check-in: 9b4e157b1e user: drh tags: trunk)
06:11
URL fix in forum.wiki ... (check-in: 542c5576b3 user: wyoung tags: trunk)
03:38
Update wording to match documentation. ... (Closed-Leaf check-in: cbfbfa8c72 user: mistachkin tags: updNewCaps)
03:21
Added the "Moderation" section to www/forum.wiki ... (check-in: e06e7f8434 user: wyoung tags: trunk)
03:00
Assorted tweaks and improvements to the new email alerts material in www/forum.wiki. ... (check-in: 4326f76f7f user: wyoung tags: trunk)
02:47
Added the "Email Notification" section to the forum.wiki document. ... (check-in: 6b2752030d user: wyoung tags: trunk)
2018-08-11
23:51
Coding style tweak. ... (Closed-Leaf check-in: 52b9caa502 user: mistachkin tags: login-with-email)
23:47
Update JSON code to account for new capabilities. Also, the 'setup' and 'admin' capabilities should imply 'debug'. ... (check-in: 7ce44fab24 user: mistachkin tags: updNewCaps)
21:04
Added forumSel adjustment advice to forum.wiki. ... (check-in: 0194fb6774 user: wyoung tags: trunk)
20:49
The periodic "updateClock()" call made in the header for several of the built-in skins (Eagle, Enhanced1, and Xekri) violates the new stricter CSP, since it requires a JS eval. We don't need an eval here: we can pass the function's name literally to window.setTimeout instead, which treats it as a Function object, which doesn't need to be eval'd. ... (check-in: eac15b4c63 user: wyoung tags: trunk)
19:43
Added the "Enable Forum Search" section to www/forum.wiki ... (check-in: cc5d2e1f17 user: wyoung tags: trunk)
19:28
Zeroed a pointer in its declaration to squish a warning from GCC 4.8.4 on Ubuntu 14.04 about use of a potentially uninitted pointer. I don't think it's actually possible for the current code to use the pointer in the window between its declaration and first use, but I think we can afford the extra machine instruction this will cost us. (I assume newer GCCs are smart enough to analyze this situation correctly, which is why the warning hasn't been squished earlier.) ... (check-in: 892781cb23 user: wyoung tags: trunk)
16:59
Fix to checkin [8c91be8b], which was intended to allow the user to log in with the email found in the contact info field of the user table. That checkin is fine as far as it goes, but it only works if the caller doesn't subsequently try to use the passed user name for anything else, since it isn't actually a user name. This checkin causes the low-level login checking function to re-point the user name pointer at the actual login name discovered while scanning for matching email addresses. ... (check-in: 33522ff4e6 user: wyoung tags: login-with-email)
2018-08-10
23:28
Try to put the human name of the person who posted on the From: line of email notifications for new forum posts. ... (check-in: ad4193315f user: drh tags: trunk)
20:30
Be sure to send forum event notifications in chronological order. ... (check-in: b460250211 user: drh tags: trunk)
17:08
Also remember the name the user for webmail. ... (check-in: 800cd27da7 user: drh tags: trunk)
16:59
Fix the webmail screen so that it remembers the folder that is being viewed. ... (check-in: e0377d04f5 user: drh tags: trunk)
16:51
Fix the /forum webpage so that it works even if the forumpost table does not exist in the repository. ... (check-in: d73c5fd27e user: drh tags: trunk)
16:44
Allow login using either the username or the first email address found in the USER.INFO column. Note that it might be useful to create an index on user(find_emailaddr(info)) to make this efficient in the case where there are many rows in the user table. ... (check-in: 8c91be8bf0 user: drh tags: trunk)
16:16
Add the find_emailaddr() SQL function. ... (check-in: 8a20d41fce user: drh tags: trunk)
2018-08-09
21:40
Remove an unused function from the backoffice.c. This problem only comes up on Windows as the function call was contained within #ifdef _WIN32. ... (check-in: 2d732f4030 user: drh tags: trunk)
16:00
Fix an unfinalized prepared statement in the "fossil bisect ui" command. ... (check-in: 148d4b6603 user: drh tags: trunk)
15:39
Improvements to formatting in generated emails to make them appear less like spam. Suggestions from "gahr" on the forum. ... (check-in: 27404ad05f user: drh tags: trunk)
14:15
Take care that a bug in the email alert sender results in missed alerts rather than an endless cascade of duplicate alerts. ... (check-in: 164c3d1a6a user: drh tags: trunk)
06:59
Minor improvements to forum.wiki ... (check-in: 635d2f6317 user: wyoung tags: trunk)
06:17
Tightned up the login-groups sub-section of the SSO section in forum.wiki. ... (check-in: 60c586d7d7 user: wyoung tags: trunk)
06:13
Tightened up the MTA point in www/forum.wiki, and added a bit about digest delivery. ... (check-in: b51d621223 user: wyoung tags: trunk)
06:04
More feature rah-rah in www/forum.wiki, plus better formatting. ... (check-in: cce5da1658 user: wyoung tags: trunk)
04:34
Clarity pass on the forum capability names in www/forum.wiki to match nomenclature on the Admin -> Users page. ... (check-in: 2490bfba99 user: wyoung tags: trunk)
03:35
Added point about multiple copies of each matching post in web search results to the forum.wiki doc. ... (check-in: 89ab99e380 user: wyoung tags: trunk)
2018-08-08
23:59
Go ahead and permanently remove the backoffice timeout mechanism, as it seems clear we will not have a use for it moving forward. ... (check-in: 4db3848752 user: drh tags: trunk)
20:56
Disable backoffice timeouts. This is a temporary measure to avoid a horrible bug in which a timeout causes the email notification sending process to exit before recording the fact that notifications have already been sent, and thus causing the same notifications to be sent again on the next backoffice cycle, and so forth over and over and over. ... (check-in: 628d63c4cf user: drh tags: trunk)
20:01
Enhance the /register page so that it also does email subscriptions if that is enabled for self-registered users. ... (check-in: 2e30828044 user: drh tags: trunk)
19:43
More SSO discussion improvements in forum.wiki ... (check-in: bc303c0ec0 user: wyoung tags: trunk)
19:30
More tweaks to the forum.wiki doc ... (check-in: 5d75504af0 user: wyoung tags: trunk)
19:25
Small tweak to the advice for "reader" category capability for forums ... (check-in: ea67aadeee user: wyoung tags: trunk)
19:22
Added the "Skin Setup" section to the new forum.wiki document ... (check-in: 3ec8f0a960 user: wyoung tags: trunk)
19:09
Expanded the SSO discussion in the new forum.wiki document ... (check-in: dd0a2dd3d3 user: wyoung tags: trunk)
18:58
Fixed some incorrect uses of Markdown backticks in a document declared as wiki format. ... (check-in: 76ca1f829f user: wyoung tags: trunk)
18:55
Link fix in previous ... (check-in: be74f25902 user: wyoung tags: trunk)
18:52
Several improvements to the new forum.wiki document ... (check-in: f85bc32619 user: wyoung tags: trunk)
18:32
Typo fix ... (check-in: 15b2034307 user: wyoung tags: trunk)
18:29
Fixed some Markdown formatting problems in www/emaildesign.md. Made a few minor grammar tweaks while in there. ... (check-in: 30716e3c7d user: wyoung tags: trunk)
18:17
Fix the backoffice processes on unix so that they close file descriptors 0, 1, and 2 and reopen them on /dev/null, so as not to interfere with parent processes in any way. Restore the default of backoffice-nodelay back to off. Remove the /test-backoffice-lease webpage, which did not work correctly. ... (check-in: c09b2512b3 user: drh tags: trunk)
18:15
Remove the /test-backoffice-lease webpage, since it doesn't really work correctly. Use only the "fossil test-backoffice-lease" command moving forward. We can wrap that command in a Wapp script if necessary. ... (Closed-Leaf check-in: b6aadace39 user: drh tags: backoffice-full-close)
18:13
Set the default backoffice-nodelay back to off. ... (check-in: 353a4e12d5 user: drh tags: backoffice-full-close)
18:10
A simpler method of ensuring that backoffice does not cling to the standard input and output. ... (check-in: 8c52c67412 user: drh tags: backoffice-full-close)
17:21
Added initial version of www/forum.wiki document and a link to it from the front page. ... (check-in: 4ed14b1f3f user: wyoung tags: trunk)
16:20
If the "fds" query parameter is provided, then the /test-backoffice-lease webpage shows the open file descriptors. ... (check-in: 918e1ddd8e user: drh tags: trunk)
14:40
Turn backoffice-nodelay on by default. ... (check-in: af599d6adc user: drh tags: trunk)
14:23
Add the /test-backoffice-lease web page. ... (check-in: 4a544e5dcb user: drh tags: trunk)
14:08
Make sure the backoffice has all file descriptors closed before it starts. ... (check-in: 15f85cfdaa user: drh tags: trunk)
13:47
Add table sorting to the subscriber list. ... (check-in: 988cf44ded user: drh tags: trunk)
13:19
Added Forum navbar before Tickets in all skins that had such a link, pointing to /forum if the user is anonymous and has capability 2 or 3, or is logged in and has any capabilities in 2-6 inclusive. ... (Closed-Leaf check-in: 4344f806d6 user: wyoung tags: forum-skin-links)
12:27
Adjust the homepage to point to the new forum instead of to the legacy mailing lists. ... (check-in: ec88836dd6 user: drh tags: trunk)
11:35
Add initial documentation about email alerts. Remove obsolete forum features from the "fossil config" command. ... (check-in: 62411f371f user: drh tags: trunk)
09:21
Update internal Unicode character tables, used in regular expression handling, from version 10.0 to 11.0. ... (check-in: 1aff43a74a user: jan.nijtmans tags: trunk)
02:21
Fix the build on unix. ... (check-in: 88240d4d4a user: drh tags: trunk)
02:15
More enhancements to backoffice diagnostics. ... (check-in: 864a6f3922 user: mistachkin tags: trunk)
01:51
Add documentation about the backoffice. ... (check-in: c6522a0fe0 user: drh tags: trunk)
00:03
Fix some compiler warnings. ... (check-in: 250fc00dd3 user: mistachkin tags: trunk)